Skip to content

feat(create-rsbuild): improve tool selection instruction in prompt#3208

Merged
chenjiahan merged 2 commits intoweb-infra-dev:mainfrom
brinzl:refactor/cli-tools-prompt-instruction
Aug 15, 2024
Merged

feat(create-rsbuild): improve tool selection instruction in prompt#3208
chenjiahan merged 2 commits intoweb-infra-dev:mainfrom
brinzl:refactor/cli-tools-prompt-instruction

Conversation

@brinzl
Copy link
Copy Markdown
Contributor

@brinzl brinzl commented Aug 15, 2024

Summary

Improve CLI prompt usability for additional tool selection. Users may be unsure on how to select additional tools, leading to confusion.

It happened to me, when I was trying to select additional tools for linting and formatting, I wasn't quite sure why hitting enter was not selecting the tools 😅

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 15, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 08d47c8
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66bd6e68bcd5a70007bbd8d7
😎 Deploy Preview https://deploy-preview-3208--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title refactor(cli): improve tool selection instruction in prompt feat(create-rsbuild): improve tool selection instruction in prompt Aug 15, 2024
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan enabled auto-merge (squash) August 15, 2024 02:58
@chenjiahan chenjiahan disabled auto-merge August 15, 2024 03:21
@chenjiahan chenjiahan merged commit a443424 into web-infra-dev:main Aug 15, 2024
@brinzl brinzl deleted the refactor/cli-tools-prompt-instruction branch September 29, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants