feat!: output inspect config to .rsbuild dir#3189
Merged
chenjiahan merged 4 commits intomainfrom Aug 12, 2024
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Aug 12, 2024
| let { cleanDistPath } = config.output; | ||
|
|
||
| if (cleanDistPath === undefined) { | ||
| cleanDistPath = isStrictSubdir(rootPath, cleanPath); |
Member
There was a problem hiding this comment.
We can avoid calling isStrictSubdir multiple times
chenjiahan
reviewed
Aug 12, 2024
| } | ||
|
|
||
| if (cleanDistPath) { | ||
| await emptyDir(cleanPath); |
Member
There was a problem hiding this comment.
emptyDir is slow, can we find a method to avoid calling it multiple times?
chenjiahan
approved these changes
Aug 12, 2024
This was referenced Aug 14, 2024
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output inspect config to
.rsbuilddirectory by default, and we will output more rsbuild related files to the.rsbuilddirectory.Related Links
Checklist