feat: more plugins support used as environment plugin#2994
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| }); | ||
| }; | ||
|
|
||
| // use modifyRsbuildConfig to get useSSR default value (can be override by pluginOptions) |
There was a problem hiding this comment.
From my perspective, we should not use the modifyRsbuildConfig to get config.
If we want to get the config, we can use api.getRsbuildConfig().
There was a problem hiding this comment.
Calling api.getRsbuildConfig() in modifyEnvironmentConfig hook is currently not supported because RsbuildConfig contains EnvironmentConfig, which has not yet been determined.
There was a problem hiding this comment.
No, it is allowed call api.getRsbuildConfig() anywhere and it should alway return the current (latest) config.
For example, if modifyRsbuildConfig has been called, api.getRsbuildConfig() should return the normalized Rsbuild config.
Summary
use
modifyEnvironmentConfiginstead ofmodifyRsbuildConfig, make more plugins support used as environment plugin.Related Links
#2986
Checklist