fix: modify the criteria for verifying the Rsdoctor plugin#2992
Merged
chenjiahan merged 1 commit intomainfrom Jul 23, 2024
Merged
fix: modify the criteria for verifying the Rsdoctor plugin#2992chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0fafa80 to
8b3a132
Compare
chenjiahan
reviewed
Jul 23, 2024
|
|
||
| let isAutoRegister = false; | ||
|
|
||
| function isRsdoctorPlugin(plugin: Configuration['plugins'] & { isRsdoctorPlugin?: boolean }) { |
Member
There was a problem hiding this comment.
function -> const + arrow function
| (plugin) => plugin?.constructor?.name === pluginName, | ||
| // If user has add Rsdoctor plugin in config file, will return. | ||
| const registered = config.plugins?.some( | ||
| (plugin) => isRsdoctorPlugin(plugin as unknown as Configuration['plugins'] & { isRsdoctorPlugin?: boolean }) || plugin?.constructor?.name === pluginName, |
Member
There was a problem hiding this comment.
We can move the plugin?.constructor?.name === pluginName to isRsdoctorPlugin() helper.
Contributor
Author
There was a problem hiding this comment.
We can move the
plugin?.constructor?.name === pluginNametoisRsdoctorPlugin()helper.
@chenjiahan I just worry about remove the plugin?.constructor?.name === pluginName may be a break change.
Member
There was a problem hiding this comment.
No, I mean move the logic to the function, not to remove it.
| (plugin) => plugin?.constructor?.name === pluginName, | ||
| // If user has add Rsdoctor plugin in config file, will return. | ||
| const registered = config.plugins?.some( | ||
| (plugin) => isRsdoctorPlugin(plugin as unknown as Configuration['plugins'] & { isRsdoctorPlugin?: boolean }) || plugin?.constructor?.name === pluginName, |
Member
There was a problem hiding this comment.
We can declare a type to reuse it
Suggested change
| (plugin) => isRsdoctorPlugin(plugin as unknown as Configuration['plugins'] & { isRsdoctorPlugin?: boolean }) || plugin?.constructor?.name === pluginName, | |
| type MaybeRsdoctorPlugin = Configuration['plugins'] & { isRsdoctorPlugin?: boolean }) |
6e9fedf to
5743aac
Compare
fix: rsdoctor plugin fix: rsdoctor plugin feat: support add plugins for specified environment (#2986) Co-authored-by: neverland <jait.chen@foxmail.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> fix: modify the criteria for verifying the Rsdoctor plugin. fix: modify the criteria for verifying the Rsdoctor plugin.
5743aac to
248a059
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: modify the criteria for verifying the Rsdoctor plugin.
Related Links
Checklist