Skip to content

types: allow passing user config to mergeEnvironmentConfig#2863

Merged
chenjiahan merged 4 commits intomainfrom
type/mergeEnvironmentConfig
Jul 10, 2024
Merged

types: allow passing user config to mergeEnvironmentConfig#2863
chenjiahan merged 4 commits intomainfrom
type/mergeEnvironmentConfig

Conversation

@9aoy
Copy link
Copy Markdown
Contributor

@9aoy 9aoy commented Jul 10, 2024

Summary

update mergeEnvironmentConfig type, support use userConfig override extraConfig fields.

const myPlugin = () => ({
  setup: (api) => {
    api.modifyEnvironmentConfig((userConfig, { mergeEnvironmentConfig }) => {
      const extraConfig: EnvironmentConfig = {
        source: {
          // ...
        },
        output: {
          // ...
        },
      };

      return mergeEnvironmentConfig(extraConfig, userConfig);
    });
  },
});

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 9e3eff4
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/668e2e3a3d695b000862568c
😎 Deploy Preview https://deploy-preview-2863--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 86 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

chenjiahan
chenjiahan reviewed Jul 10, 2024
View reviewed changes
chenjiahan
chenjiahan reviewed Jul 10, 2024
View reviewed changes
chenjiahan
chenjiahan reviewed Jul 10, 2024
View reviewed changes
@chenjiahan chenjiahan changed the title feat(types): support use userConfig override extraConfig fields in mergeEnvironmentConfig feat(types): support passing user config to mergeEnvironmentConfig Jul 10, 2024
@chenjiahan chenjiahan changed the title feat(types): support passing user config to mergeEnvironmentConfig types: allow passing user config to mergeEnvironmentConfig Jul 10, 2024
@chenjiahan chenjiahan merged commit b32983f into main Jul 10, 2024
@chenjiahan chenjiahan deleted the type/mergeEnvironmentConfig branch July 10, 2024 07:01
@9aoy 9aoy mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

release: feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@9aoy @chenjiahan