perf!: remove builtin terser HTML minimizer#2833
Merged
chenjiahan merged 8 commits intomainfrom Jul 8, 2024
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jul 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
BREAKING CHANGES:
html-rspack-plugin6.0.0 alpha, remove builtin terser HTML minimizer.output.minify.htmlandoutput.minify.htmlOptionsoptions.Motivation
Rsbuild
1.0.0-alpha.6removed theoutput.minify.htmlandoutput.minify.htmlOptionsoptions, and no longer minify the HTML files.Previously Rsbuild uses
html-minifier-terserto minify the HTML files. But the performance ofhtml-minifier-tersercan not meet the needs of Rsbuild applications, and In most cases, there is little benefit in compressing HTML.At this stage, we do not want to builtin
html-minifier-terser, so we provide a standalone rsbuild-plugin-html-minifier-terser to support HTML minification.And we plan to use some faster Rust-based HTML minimizer in the future.
Related Links
rstackjs/html-rspack-plugin#2
Checklist