Skip to content

perf: read file async when printing file size#2820

Merged
chenjiahan merged 1 commit intomainfrom
read_file_async_0706
Jul 6, 2024
Merged

perf: read file async when printing file size#2820
chenjiahan merged 1 commit intomainfrom
read_file_async_0706

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

Should read file async when printing file size.

Tested in https://github.com/liangyuetian/rsbuild-hmr-slow-demo:

  • before (54ms):
截屏2024-07-06 18 25 38
  • after (15ms):
截屏2024-07-06 18 26 54

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 6, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 3d05331
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66891ceb568d070008080702
😎 Deploy Preview https://deploy-preview-2820--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🟢 up 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit b37d4be into main Jul 6, 2024
@chenjiahan chenjiahan deleted the read_file_async_0706 branch July 6, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant