Skip to content

fix: hmr failed when adding initial chunk#2743

Merged
chenjiahan merged 11 commits intoweb-infra-dev:mainfrom
SoonIter:test
Jul 5, 2024
Merged

fix: hmr failed when adding initial chunk#2743
chenjiahan merged 11 commits intoweb-infra-dev:mainfrom
SoonIter:test

Conversation

@SoonIter
Copy link
Copy Markdown
Member

@SoonIter SoonIter commented Jul 1, 2024 •
edited
Loading

Summary

beyond webpack

Related Links

web-infra-dev/rspack#6633

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 1, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit c678cf4
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/668802f69653990008ffc9d1
😎 Deploy Preview https://deploy-preview-2743--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 79 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter force-pushed the test branch 2 times, most recently from 5ffea58 to b4358bf Compare July 2, 2024 06:51
@SoonIter
Copy link
Copy Markdown
Member Author

SoonIter commented Jul 2, 2024

image first commit is about the failed case

@SoonIter SoonIter force-pushed the test branch 5 times, most recently from 09a0776 to f526465 Compare July 3, 2024 03:10
@SoonIter SoonIter requested review from 9aoy and chenjiahan July 3, 2024 03:43
@SoonIter SoonIter marked this pull request as ready for review July 3, 2024 03:43
chenjiahan
chenjiahan reviewed Jul 3, 2024
View reviewed changes
Comment thread e2e/cases/lazy-compilation/add-initial-chunk/index.test.ts
Comment thread e2e/cases/lazy-compilation/add-initial-chunk/rsbuild.config.ts Outdated
Comment thread packages/core/src/server/socketServer.ts Outdated
Comment thread packages/core/src/server/socketServer.ts Outdated
@SoonIter SoonIter force-pushed the test branch 3 times, most recently from 4ef0192 to 52f8330 Compare July 3, 2024 06:48
@SoonIter
Copy link
Copy Markdown
Member Author

SoonIter commented Jul 3, 2024

what? it works fine on my machine...😎
image

@SoonIter SoonIter force-pushed the test branch 3 times, most recently from 991f5ed to acd532c Compare July 5, 2024 09:01
@SoonIter SoonIter requested a review from chenjiahan July 5, 2024 10:03
chenjiahan
chenjiahan reviewed Jul 5, 2024
View reviewed changes
Comment thread packages/core/src/server/socketServer.ts Outdated
Comment thread packages/core/src/server/socketServer.ts Outdated
Comment thread packages/core/src/server/socketServer.ts Outdated
@SoonIter SoonIter requested a review from chenjiahan July 5, 2024 14:40
@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Jul 5, 2024

awesome 👍

@chenjiahan chenjiahan merged commit 40d9f3f into web-infra-dev:main Jul 5, 2024
@SoonIter SoonIter deleted the test branch July 5, 2024 23:21
@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Jul 6, 2024

The new e2e case is unstable:
https://github.com/web-infra-dev/rsbuild/actions/runs/9814785645/job/27102901346

image

@chenjiahan chenjiahan mentioned this pull request Jul 7, 2024
Merged
@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Jul 8, 2024

@SoonIter The new e2e has been failed several times, can we skip it?

https://github.com/web-infra-dev/rsbuild/actions/runs/9833758635/job/27144482905?pr=2831

@SoonIter
Copy link
Copy Markdown
Member Author

SoonIter commented Jul 8, 2024

@SoonIter The new e2e has been failed several times, can we skip it?

web-infra-dev/rsbuild/actions/runs/9833758635/job/27144482905?pr=2831

Is it consistent with the reason for this?

rsbuild/e2e/cases/lazy-compilation/basic/index.test.ts

Lines 7 to 9 in 2045d39

// TODO fix this case in Windows
if (process.platform === 'win32') {
test.skip();

I'll send a pr

@SoonIter SoonIter mentioned this pull request Jul 8, 2024
Merged
@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Jul 8, 2024

Yeah, should be the same reason

@chenjiahan chenjiahan mentioned this pull request Dec 30, 2025
Merged
2 tasks
@chenjiahan chenjiahan mentioned this pull request Feb 25, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@9aoy 9aoy Awaiting requested review from 9aoy

Assignees

No one assigned

Labels

release: bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SoonIter @chenjiahan