fix(ci): use canary specific version instead of npm tag#2720
Merged
chenjiahan merged 2 commits intoweb-infra-dev:mainfrom Jun 28, 2024
Merged
fix(ci): use canary specific version instead of npm tag#2720chenjiahan merged 2 commits intoweb-infra-dev:mainfrom
chenjiahan merged 2 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
approved these changes
Jun 28, 2024
Contributor
|
Can we write a simple script to bump rspack canary version automatically? |
Member
Author
🚀🚀🚀 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/web-infra-dev/web-infra-QoS/blob/c9e4cb93b3c89fb63484f6c0646c612af9071d30/scripts/src/shared/git.ts#L78-L79
We don't use
--frozen-lockfilehere because of the cases workspace.then get the installment result below 😅
old-canary-version(in lockfile): 0.7.5-canary-6253334-20240626035254 new-canary-version: 0.7.5-canary-cff3bb0-20240627062412 @rspack/core-canary@old-canary-version └── @rspack/binding-canary@new-canary-version └── @rspack/binding-linux-x64-gnu-canary@new-canary-versionand we get the error
https://github.com/web-infra-dev/rspack/blob/b157267cfe989e0b45d88220945741f5382b96e1/packages/rspack/src/util/bindingVersionCheck.ts#L136
This error does not seem to terminate the entire dev process, causing our ci to be stuck.
Related Links
https://github.com/web-infra-dev/web-infra-QoS/actions/runs/9707169745/job/26791932553
Checklist