Skip to content

fix(plugin/assets-retry): repeated retrying of async css chunk#2645

Merged
chenjiahan merged 8 commits intoweb-infra-dev:mainfrom
SoonIter:fix/retry-async-css-chunk
Jul 3, 2024
Merged

fix(plugin/assets-retry): repeated retrying of async css chunk#2645
chenjiahan merged 8 commits intoweb-infra-dev:mainfrom
SoonIter:fix/retry-async-css-chunk

Conversation

@SoonIter
Copy link
Copy Markdown
Member

@SoonIter SoonIter commented Jun 20, 2024 •
edited
Loading

Summary

  1. async css chunk file will be repeatedly retried by both initialChunkRetry and asyncChunkRetry
  1. fix it doesn't append script when using publicPath: "auto"
image
  1. add isAsyncChunk: boolean to context

Related Links

none

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 20, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit bd5bc43
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6684c942d091d70008588e05
😎 Deploy Preview https://deploy-preview-2645--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 81 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter force-pushed the fix/retry-async-css-chunk branch 6 times, most recently from b49b3e0 to 01d85a2 Compare June 27, 2024 12:28
@SoonIter SoonIter force-pushed the fix/retry-async-css-chunk branch from 0d647c9 to 479a03e Compare July 2, 2024 01:36
@SoonIter SoonIter marked this pull request as ready for review July 2, 2024 01:58
@SoonIter SoonIter force-pushed the fix/retry-async-css-chunk branch from e926c5f to 82d59fc Compare July 2, 2024 07:34
@SoonIter SoonIter requested a review from chenjiahan July 2, 2024 07:34
chenjiahan
chenjiahan reviewed Jul 2, 2024
View reviewed changes
SoonIter
SoonIter commented Jul 2, 2024
View reviewed changes
@SoonIter SoonIter force-pushed the fix/retry-async-css-chunk branch from 0a135ef to 5783b71 Compare July 2, 2024 09:09
chenjiahan
chenjiahan approved these changes Jul 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan enabled auto-merge (squash) July 2, 2024 09:13
@SoonIter SoonIter force-pushed the fix/retry-async-css-chunk branch from 5783b71 to bd5bc43 Compare July 3, 2024 03:45
@chenjiahan chenjiahan merged commit 7c38434 into web-infra-dev:main Jul 3, 2024
@chenjiahan chenjiahan mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

release: bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SoonIter @chenjiahan