Skip to content

feat: allow to use port placeholder in client.port#2641

Merged
chenjiahan merged 1 commit intomainfrom
port_placeholder_0620
Jun 20, 2024
Merged

feat: allow to use port placeholder in client.port#2641
chenjiahan merged 1 commit intomainfrom
port_placeholder_0620

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

Allow to use '<port>' placeholder in client.port.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 20, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 34a87c9
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6673cb78017486000834f880
😎 Deploy Preview https://deploy-preview-2641--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 552facf into main Jun 20, 2024
@chenjiahan chenjiahan deleted the port_placeholder_0620 branch June 20, 2024 06:49
@colinaaa
Copy link
Copy Markdown
Contributor

colinaaa commented Jul 3, 2024

Can we useport as the default value of client.port?

@chenjiahan
Copy link
Copy Markdown
Member Author

No, see #2639 for some backgrounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants