Skip to content

add get_vector to all vector inputs#851

Merged
tsmith023 merged 6 commits intomainfrom
allow-parsing-of-ds-vectors-in-queries
Feb 5, 2024
Merged

add get_vector to all vector inputs#851
tsmith023 merged 6 commits intomainfrom
allow-parsing-of-ds-vectors-in-queries

Conversation

@tsmith023
Copy link
Collaborator

No description provided.

@tsmith023 tsmith023 requested a review from dirkkul February 2, 2024 14:12
Copy link
Collaborator

@dirkkul dirkkul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please alsoa dd it for insert_many :)

@tsmith023
Copy link
Collaborator Author

please alsoa dd it for insert_many :)

The _BatchGRPC class calls the function when it packs the vector into bytes

@codecov-commenter
Copy link

Codecov Report

Attention: 274 lines in your changes are missing coverage. Please review.

Comparison is base (e977081) 93.48% compared to head (00d1b15) 95.47%.
Report is 58 commits behind head on main.

Files Patch % Lines
integration/test_collection_openai.py 41.25% 84 Missing ⚠️
weaviate/collections/batch/base.py 82.10% 51 Missing ⚠️
integration/test_collection_rerank.py 32.69% 35 Missing ⚠️
integration/test_batch_v4.py 95.08% 14 Missing ⚠️
integration_v3/test_backup_v4.py 92.76% 11 Missing ⚠️
mock_tests/test_collection.py 85.71% 10 Missing ⚠️
weaviate/collections/aggregations/base.py 94.57% 9 Missing ⚠️
integration/test_collection.py 99.05% 8 Missing ⚠️
weaviate/collections/batch/batch_wrapper.py 86.20% 8 Missing ⚠️
integration/conftest.py 88.52% 7 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
+ Coverage   93.48%   95.47%   +1.99%     
==========================================
  Files          70      167      +97     
  Lines        8625    17111    +8486     
==========================================
+ Hits         8063    16337    +8274     
- Misses        562      774     +212     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 merged commit 052e18e into main Feb 5, 2024
@tsmith023 tsmith023 deleted the allow-parsing-of-ds-vectors-in-queries branch February 5, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants