Feature: add .with_limit() method to AggregateBuilder#369
Merged
dirkkul merged 5 commits intoweaviate:mainfrom Jul 6, 2023
Merged
Feature: add .with_limit() method to AggregateBuilder#369dirkkul merged 5 commits intoweaviate:mainfrom
dirkkul merged 5 commits intoweaviate:mainfrom
Conversation
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 95.63% 95.30% -0.34%
==========================================
Files 64 64
Lines 7836 8151 +315
==========================================
+ Hits 7494 7768 +274
- Misses 342 383 +41
☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
I agree with the Contributor License Agreement (CLA) |
dirkkul
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using the
limitargument onAggregatequeries through the.with_limit()builder method of theAggregateBuilderclass as requested in #361.Since its function is dependent on the presence of other filters, it is only included when they are also. Unit and integration tests are added to handle the new features. There are no client-side data validation checks so that any user mishap will be reported as as errors from Weaviate itself, as per the rest of the codebase.
@dirkkul, let me know if this is inline with your thoughts on the feature and whether further changes are required!