feature/287 warn when weaviate client outdated#343
Merged
dirkkul merged 7 commits intoweaviate:mainfrom Jul 6, 2023
Merged
Conversation
Adds a helper function in utils to compare current and latest version strings. Adds a new static warning method with appropriate message. Fetches latest version from pypi when initialising a connection.
…o feature/287-Warn_when_weaviate_client_outdated
Add unit tests
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Contributor
Author
|
I agree ✅ |
dirkkul
reviewed
Jun 12, 2023
Collaborator
dirkkul
left a comment
There was a problem hiding this comment.
Thank you for your contribution! There are some minor issues, would be great if you could fix those. In addition to the comments it would also be great if you could run black to fix the linter issues.
Sorry that my review took so long, I was on holiday :)
…o feature/287-Warn_when_weaviate_client_outdated
Dep004 corrected to be Dep005
use pytest+parametrization on the test for outdated client check
Run the linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #287 :: warn when weaviate client outdated
__version__and warns the user if more than 3 minor versions behind