Skip to content

Add embedded support for mac os#337

Merged
dirkkul merged 5 commits intomainfrom
embedded_mac
Jun 16, 2023
Merged

Add embedded support for mac os#337
dirkkul merged 5 commits intomainfrom
embedded_mac

Conversation

@dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented May 19, 2023

  • Add binaries to weaviate releases
  • handle darwin plattform in automatic file download

@dirkkul dirkkul marked this pull request as draft May 19, 2023 14:44
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.07 ⚠️

Comparison is base (c1cfaff) 95.74% compared to head (9d21daa) 95.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   95.74%   95.68%   -0.07%     
==========================================
  Files          64       64              
  Lines        7798     7805       +7     
==========================================
+ Hits         7466     7468       +2     
- Misses        332      337       +5     
Impacted Files Coverage Δ
weaviate/embedded.py 92.90% <64.28%> (-3.37%) ⬇️
weaviate/gql/get.py 97.17% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dirkkul dirkkul marked this pull request as ready for review June 15, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants