Skip to content

Use LLVM_PROFILE_FILE for test coverage#4367

Merged
Spxg merged 4 commits into
wasm-bindgen:mainfrom
daxpedda:llvm-profile-file
Dec 10, 2025
Merged

Use LLVM_PROFILE_FILE for test coverage#4367
Spxg merged 4 commits into
wasm-bindgen:mainfrom
daxpedda:llvm-profile-file

Conversation

@daxpedda

@daxpedda daxpedda commented Dec 19, 2024

Copy link
Copy Markdown
Member

This PR removes WASM_BINDGEN_UNSTABLE_TEST_PROFRAW_OUT and WASM_BINDGEN_UNSTABLE_TEST_PROFRAW_PREFIX in favor of parsing LLVM_PROFILE_FILE exactly like Rust (LLVM really) does.

Depends on Amanieu/minicov#27.

@daxpedda daxpedda force-pushed the llvm-profile-file branch 2 times, most recently from 5b1ba32 to 6aaed54 Compare December 19, 2024 18:42
@Spxg

Spxg commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Amanieu/minicov@3fdbc18

Great! I think we can proceed with this PR now.

@Spxg Spxg force-pushed the llvm-profile-file branch from 6aaed54 to c495ace Compare December 9, 2025 16:07
@codspeed-hq

codspeed-hq Bot commented Dec 9, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #4367 will not alter performance

Comparing daxpedda:llvm-profile-file (45e056c) with main (d2f92bf)

Summary

✅ 4 untouched

@Spxg Spxg force-pushed the llvm-profile-file branch 4 times, most recently from 7d7419d to 896a716 Compare December 9, 2025 17:00
@Spxg Spxg marked this pull request as ready for review December 9, 2025 17:05
@Spxg Spxg requested a review from a team December 9, 2025 17:07
@Spxg Spxg force-pushed the llvm-profile-file branch from 842cd8e to 45e056c Compare December 10, 2025 02:10
@Spxg Spxg merged commit 315cfa1 into wasm-bindgen:main Dec 10, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants