CanvasRenderingContext2d.get_image_data argument is float#1920
Merged
Conversation
Contributor
|
Thanks for this! This is unfortunately a breaking change though and once that others are probably already relying on, so I've tagged this for the next breaking release of web-sys. |
Contributor
Author
|
@alexcrichton |
Contributor
|
Indeed! |
Contributor
|
I've rebased this, and altered the approach to use the unstable merge functionality for web-sys so it will be available behind the web_sys_unstable_apis cfg. This way we can land it now and stabilize for the next web-sys major. |
guybedford
approved these changes
Feb 19, 2026
Per the HTML spec, getImageData and putImageData should use long (i32) for coordinates, not double (f64). This adds spec-compliant methods under the unstable feature flag. Closes wasm-bindgen#1917 Co-authored-by: poccariswet <poccariswet@gmail.com>
This was referenced Feb 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #1917
according to the spec it should be
i32.It also fix putImageData