fix(artifacts): fetch artifactManifest more lazily and use manifest metadata from GraphQL#10680

Merged

tonyyli-wandb merged 7 commits intomainfrom

tonyyli/fix_artifacts_fetch_artifactmanifest_more_lazily_and_manifest_metadata_via_graphql

Oct 15, 2025

Contributor

tonyyli-wandb commented Oct 9, 2025 •

edited

Loading

Description

Fixes https://wandb.atlassian.net/browse/WB-28129

PR:

updates handling of Artifact.manifest so that we delay downloading and generating the download URL for the artifact manifest until they are first used.
ensures that if the manifest has not been locally set or modified, Artifact.size and Artifact.digest can return without (re-)fetching it.

I updated CHANGELOG.unreleased.md, or it's not applicable

Testing

How was this PR tested?


          fix(artifacts): fetch artifactManifest more lazily and manifest metad…

961c07b

…ata via GraphQL

tonyyli-wandb requested review from a team as code owners

October 9, 2025 21:25

Contributor Author

tonyyli-wandb commented Oct 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov Bot commented Oct 9, 2025 •

edited

Loading

Codecov Report

❌ Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
wandb/sdk/artifacts/artifact.py	92.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

tonyyli-wandb marked this pull request as draft

October 9, 2025 22:46

tonyyli-wandb force-pushed the tonyyli/fix_artifacts_fetch_artifactmanifest_more_lazily_and_manifest_metadata_via_graphql branch from 2facd01 to ef8d813 Compare

October 9, 2025 23:35

tonyyli-wandb changed the title ~~fix(artifacts): fetch artifactManifest more lazily and manifest metadata via GraphQL~~ fix(artifacts): fetch artifactManifest more lazily and use manifest metadata from GraphQL


          changelog

1836b5b

tonyyli-wandb marked this pull request as ready for review

October 9, 2025 23:52

tonyyli-wandb commented

View reviewed changes

wandb/apis/public/api.py Outdated

tonyyli-wandb commented

View reviewed changes

wandb/sdk/artifacts/artifact.py

tonyyli-wandb commented

View reviewed changes

wandb/sdk/artifacts/artifact.py

tonyyli-wandb commented

View reviewed changes

wandb/sdk/artifacts/artifact.py Outdated

tonyyli-wandb commented

View reviewed changes

wandb/sdk/artifacts/artifact.py

tonyyli-wandb commented

View reviewed changes

wandb/sdk/artifacts/artifact_manifests/artifact_manifest_v1.py Outdated

tonyyli-wandb commented

View reviewed changes

tools/graphql_codegen/artifacts/artifacts.toml Outdated


          fix tests

d9fce1b

tonyyli-wandb force-pushed the tonyyli/fix_artifacts_fetch_artifactmanifest_more_lazily_and_manifest_metadata_via_graphql branch from 89178b7 to 7b74c37 Compare

October 10, 2025 00:22

tonyyli-wandb commented

View reviewed changes

wandb/sdk/artifacts/artifact.py Outdated

tonyyli-wandb force-pushed the tonyyli/fix_artifacts_fetch_artifactmanifest_more_lazily_and_manifest_metadata_via_graphql branch 7 times, most recently from ed00b1e to 9ddcde1 Compare

October 13, 2025 01:19

tonyyli-wandb commented

View reviewed changes

tools/graphql_codegen/artifacts/artifacts.graphql

tonyyli-wandb force-pushed the tonyyli/fix_artifacts_fetch_artifactmanifest_more_lazily_and_manifest_metadata_via_graphql branch from 9ddcde1 to 24b83b9 Compare

October 15, 2025 16:32


          rename _gqlutils -> _clientutils

952b6bd

tonyyli-wandb added 2 commits

October 15, 2025 14:50


          revert rename

5a362d8


          avoid shared session for now

tonyyli-wandb requested a review from timoffex

October 15, 2025 23:16

tonyyli-wandb force-pushed the tonyyli/fix_artifacts_fetch_artifactmanifest_more_lazily_and_manifest_metadata_via_graphql branch from 899c276 to a676003 Compare

October 15, 2025 23:16

timoffex approved these changes

View reviewed changes


          changelog edits for clarity

a5a8df5

tonyyli-wandb force-pushed the tonyyli/fix_artifacts_fetch_artifactmanifest_more_lazily_and_manifest_metadata_via_graphql branch from a676003 to a5a8df5 Compare

October 15, 2025 23:24

tonyyli-wandb enabled auto-merge (squash)

October 15, 2025 23:25

tonyyli-wandb merged commit 7f4ab78 into main

34 checks passed

tonyyli-wandb deleted the tonyyli/fix_artifacts_fetch_artifactmanifest_more_lazily_and_manifest_metadata_via_graphql branch

October 15, 2025 23:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet