fix(sdk): use explict api key before thread local#10657
Merged
dmitryduev merged 1 commit intomainfrom Oct 8, 2025
Merged
Conversation
6e2e365 to
c5e4950
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
c5e4950 to
1501760
Compare
pingleiwandb
commented
Oct 7, 2025
1501760 to
19c53eb
Compare
timoffex
approved these changes
Oct 8, 2025
jacobromero
approved these changes
Oct 8, 2025
This allow user to use different keys without picking up wrong key from thread local.
19c53eb to
7e8da98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No JIRA
User explicitly pass api key in
wandb.Api(api_key=...)was picking up wrong key from thread local when switching between different keys.The API key resolve logic should prefer the explicit key over the implicit thread local values.
Testing
How was this PR tested?
Manual test