fix: excessive data uploads when calling run.save() repeatedly on unchanged files#10639
Merged
dmitryduev merged 16 commits intomainfrom Oct 6, 2025
Merged
fix: excessive data uploads when calling run.save() repeatedly on unchanged files#10639dmitryduev merged 16 commits intomainfrom
run.save() repeatedly on unchanged files#10639dmitryduev merged 16 commits intomainfrom
Conversation
…edup-live-uploads
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jacobromero
reviewed
Oct 3, 2025
timoffex
reviewed
Oct 3, 2025
dmitryduev
commented
Oct 4, 2025
timoffex
reviewed
Oct 4, 2025
timoffex
approved these changes
Oct 4, 2025
run.save() repeatedly on unchanged files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Older versions (pre 0.18.0) of the SDK had deduplication logic for saving files absent in
wandb-core: tracking file sizes and modification dates for successfully uploaded files to prevent re-upload. This PR adds similar logic towandb-corethat relies on the hashed content of the file (instead of size and mdate).The script used for testing:
See https://wandb.ai/trustmebro/file-sync-test/.
Testing
Added unit tests.