Adding decode_uri to reverse Rison's _distinctive_ encode_uri method#2
Merged
w33ble merged 1 commit intow33ble:masterfrom Oct 19, 2018
Merged
Adding decode_uri to reverse Rison's _distinctive_ encode_uri method#2w33ble merged 1 commit intow33ble:masterfrom
w33ble merged 1 commit intow33ble:masterfrom
Conversation
Contributor
Author
|
Oh, sorry, I'm not sure if I should have done anything to automate/flag this, but this would be a minor semver change... |
Owner
|
You’re good, and thanks for contribution. I’ll try taking a look at it tomorrow. |
Owner
|
@fabio-looker FYI, I'm planning to cut a new release soon, but I'd like to get types added before I do and I still need to learn how all that works. I'll get a new release out this week regardless. |
Contributor
Author
|
No rush at all an on my end. My projects already workaround this, the PR was more about sharing the functionality with others who use the library in the future |
Owner
|
@fabio-looker I cut 2.1.0 today. The type stuff is taking me much longer to get to than I'd hoped, but at least you can use your feature now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-existence of any function (or pair of functions) in Rison or vanilla JS that can reverse rison.encode_uri was a bit unfortunate, as I first reported in Nanonid/rison#26
Now that I found a fork that seems to be maintained, I thought I would contribute the missing method, rison.decode_uri