fix: filter invalid query params without failing to match

posva · posva · commit db7178a5945d · 2026-05-20T12:41:52.000+02:00
diff --git a/packages/router/src/experimental/route-resolver/matchers/matcher-pattern-query.spec.ts b/packages/router/src/experimental/route-resolver/matchers/matcher-pattern-query.spec.ts
@@ -220,14 +220,24 @@ describe('MatcherPatternQueryParam', () => {
       expect(matcher.build({ count: 42 })).toEqual({ c: '42' })
     })
 
-    it('throws on error without default', () => {
+    it('swallows parser miss for optional param without default', () => {
       const matcher = new MatcherPatternQueryParam(
         'count',
         'c',
         'value',
         PARAM_PARSER_INT
       )
-      expect(() => matcher.match({ c: 'invalid' })).toThrow(MatchMiss)
+      // optional query params should not propagate parser misses
+      expect(matcher.match({ c: 'invalid' })).toEqual({ count: undefined })
+    })
+
+    it('swallows parser miss for optional array param without default', () => {
+      const matcher = new MatcherPatternQueryParam('ids', 'id', 'array', {
+        get: () => {
+          throw new MatchMiss()
+        },
+      })
+      expect(matcher.match({ id: ['1', '2'] })).toEqual({ ids: undefined })
     })
 
     it('falls back to default on parser error', () => {
diff --git a/packages/router/src/experimental/route-resolver/matchers/matcher-pattern-query.ts b/packages/router/src/experimental/route-resolver/matchers/matcher-pattern-query.ts
@@ -64,9 +64,9 @@ export class MatcherPatternQueryParam<
             valueBeforeParse
           ) as T
         } catch (error) {
-          // if there is a miss but we have a default, use it
-          // otherwise rethrow the error
-          if (this.defaultValue === undefined) {
+          // only propagate the miss for required params without a default
+          // otherwise let the value fall back to the default (or undefined)
+          if (this.required && this.defaultValue === undefined) {
             throw error
           }
           // ensure the default value is used
@@ -83,7 +83,9 @@ export class MatcherPatternQueryParam<
                 valueBeforeParse
               ) as T)
       } catch (error) {
-        if (this.defaultValue === undefined) {
+        // only propagate the miss for required params without a default
+        // otherwise let the value fall back to the default (or undefined)
+        if (this.required && this.defaultValue === undefined) {
           throw error
         }
       }
