fix: cleanup old route overrides

posva · posva · commit b28a71e2602d · 2026-02-10T11:03:14.000+01:00
diff --git a/packages/router/src/unplugin/core/tree.spec.ts b/packages/router/src/unplugin/core/tree.spec.ts
@@ -814,6 +814,22 @@ describe('Tree', () => {
     expect(`"(home" is missing the closing ")"`).toHaveBeenWarned()
   })
 
+  it('overrides existing properties with setCustomRouteBlock', () => {
+    const tree = new PrefixTree(RESOLVED_OPTIONS)
+    const page = tree.insert('page', 'page.vue')
+    page.setCustomRouteBlock('page.vue', {
+      alias: ['/home'],
+      name: 'Page',
+    })
+    // same as editing the file
+    page.setCustomRouteBlock('page.vue', {
+      // we drop the name
+      alias: ['/other'],
+    })
+    expect(page.alias).toEqual(['/other'])
+    expect(page.name).toBe('/page')
+  })
+
   describe('path regexp', () => {
     function checkRegexp(
       path: string,
diff --git a/packages/router/src/unplugin/core/tree.ts b/packages/router/src/unplugin/core/tree.ts
@@ -147,8 +147,8 @@ export class TreeNode {
   }
 
   /**
-   * Saves a custom route block for a specific file path. The file path is used as a key. Some special file paths will
-   * have a lower or higher priority.
+   * Saves a custom route block for a specific file path. The file path is used
+   * as a key. Some special file paths will have a lower or higher priority.
    *
    * @param filePath - file path where the custom block is located
    * @param routeBlock - custom block to set
@@ -157,12 +157,7 @@ export class TreeNode {
     filePath: string,
     routeBlock: CustomRouteBlock | undefined
   ) {
-    // FIXME: No, we can't do this because we are adding stuff this way like aliases are never removed
-    // Use mergeOverride to preserve existing override properties (e.g. name: false for _parent routes)
-    // this.value.setOverride(filePath, routeBlock)
-    if (routeBlock) {
-      this.value.mergeOverride(filePath, routeBlock)
-    }
+    this.value.setOverride(filePath, routeBlock)
   }
 
   /**
@@ -272,6 +267,13 @@ export class TreeNode {
     return this.value.fullPath
   }
 
+  /**
+   * Returns the alias of the node
+   */
+  get alias(): string[] {
+    return this.value.alias
+  }
+
   /**
    * Object of components (filepaths) for this node.
    */
