fix(language-service): re-support html.customData#5910
Merged
Conversation
…cache the results so they are only fetched once
Contributor
Author
|
Please let me know what I can do to resolve this failing check. |
Member
|
Just helped you to fix the "Auto Fix" check. You can run the following command next time. pnpm format && pnpm lint:fix |
9c1fd47 to
c8e90e4
Compare
html.customData
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #5926
As mentioned in issue: #3975, many users still experience issues when they want to use custom elements via: vscode custom data definition (https://github.com/microsoft/vscode-custom-data).
This feature enables code completion for custom web components that do not have dedicated vue components (for example UI5 Web Components ).
This change will check if user has defined custom html data via .vscode/settings.json and load the files:
{ "html.customData": [ "./node_modules/@ui5/webcomponents/dist/vscode.html-custom-data.json", "./node_modules/@ui5/webcomponents-fiori/dist/vscode.html-custom-data.json" ] }Below short example how the editor will look like with and without these changes.