fix(runtime-core): pause tracking when invoking function refs by edison1105 · Pull Request #14985 · vuejs/core

edison1105 · 2026-06-18T08:48:55Z

Summary by CodeRabbit

Bug Fixes
- Fixed function ref callbacks to prevent unintended re-invocation when reactive dependencies are accessed within the callback body.
Tests
- Added test coverage for function ref callback tracking behavior.

coderabbitai · 2026-06-18T08:49:09Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 217c6596-34c3-46a0-8a63-e2e5b41a9b2d

📥 Commits

Reviewing files that changed from the base of the PR and between 325eb1d and c8140cc.

📒 Files selected for processing (2)

packages/runtime-core/__tests__/rendererTemplateRef.spec.ts
packages/runtime-core/src/rendererTemplateRef.ts

📝 Walkthrough

Walkthrough

rendererTemplateRef.ts imports pauseTracking and resetTracking from @vue/reactivity and wraps the function-ref invocation (callWithErrorHandling) in a pauseTracking/try-finally/resetTracking block. A new test verifies the callback is called once on mount and not re-invoked after a reactive dependency changes.

Function ref tracking suppression

Layer / File(s)	Summary
Suppress tracking in function ref callbacks `packages/runtime-core/src/rendererTemplateRef.ts`, `packages/runtime-core/__tests__/rendererTemplateRef.spec.ts`	Adds `pauseTracking`/`resetTracking` imports and wraps the `callWithErrorHandling` call for function refs in a `try/finally` block so callbacks cannot create reactive subscriptions. A new async test confirms the callback fires once on mount and not again after `nextTick` despite reading reactive state inside the callback.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Suggested labels

:hammer: p3-minor-bug

Poem

🐇 A ref once chased reactive deps with glee,
Re-running each tick — oh, unbounded was she!
But pauseTracking stepped in, calm and neat,
Wrapped the callback so tracking would sleep.
Now refs fire once, as all good refs should be! 🌿

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: pausing tracking when invoking function refs in runtime-core, which is exactly what the implementation does.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch edison/fix/runtime-core-function-ref-tracking

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-18T08:50:11Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	106 kB (+24 B)	40.2 kB (+4 B)	36.1 kB (+19 B)
vue.global.prod.js	164 kB (+24 B)	60.2 kB (+3 B)	53.5 kB (+52 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	48.8 kB (+24 B)	19 kB (+10 B)	17.4 kB (+13 B)
createApp	56.9 kB (+24 B)	22 kB (+4 B)	20.1 kB (+4 B)
createSSRApp	61.2 kB (+24 B)	23.8 kB (+5 B)	21.7 kB (+8 B)
defineCustomElement	63.1 kB (+24 B)	23.9 kB (+3 B)	21.8 kB (+17 B)
overall	71.7 kB (+24 B)	27.4 kB (+5 B)	25 kB (+68 B)

pkg-pr-new · 2026-06-18T08:50:12Z

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14985

npm i https://pkg.pr.new/@vue/compiler-core@14985

yarn add https://pkg.pr.new/@vue/compiler-core@14985.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14985

npm i https://pkg.pr.new/@vue/compiler-dom@14985

yarn add https://pkg.pr.new/@vue/compiler-dom@14985.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14985

npm i https://pkg.pr.new/@vue/compiler-sfc@14985

yarn add https://pkg.pr.new/@vue/compiler-sfc@14985.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14985

npm i https://pkg.pr.new/@vue/compiler-ssr@14985

yarn add https://pkg.pr.new/@vue/compiler-ssr@14985.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14985

npm i https://pkg.pr.new/@vue/reactivity@14985

yarn add https://pkg.pr.new/@vue/reactivity@14985.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14985

npm i https://pkg.pr.new/@vue/runtime-core@14985

yarn add https://pkg.pr.new/@vue/runtime-core@14985.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14985

npm i https://pkg.pr.new/@vue/runtime-dom@14985

yarn add https://pkg.pr.new/@vue/runtime-dom@14985.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14985

npm i https://pkg.pr.new/@vue/server-renderer@14985

yarn add https://pkg.pr.new/@vue/server-renderer@14985.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14985

npm i https://pkg.pr.new/@vue/shared@14985

yarn add https://pkg.pr.new/@vue/shared@14985.tgz

vue

pnpm add https://pkg.pr.new/vue@14985

npm i https://pkg.pr.new/vue@14985

yarn add https://pkg.pr.new/vue@14985.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14985

npm i https://pkg.pr.new/@vue/compat@14985

yarn add https://pkg.pr.new/@vue/compat@14985.tgz

commit: c8140cc

edison1105 · 2026-06-18T08:51:17Z

/ecosystem-ci run

vue-bot · 2026-06-18T09:10:11Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
pinia	✅ success	✅ success
quasar	✅ success	✅ success
primevue	✅ success	✅ success
nuxt	✅ success	✅ success
radix-vue	❌ failure	❌ failure
vite-plugin-vue	✅ success	✅ success
vueuse	✅ success	✅ success
vue-macros	✅ success	✅ success
vitepress	✅ success	✅ success
router	✅ success	✅ success
test-utils	✅ success	✅ success
vue-i18n	✅ success	✅ success
language-tools	✅ success	✅ success
vant	✅ success	✅ success
vuetify	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success

vuejs/core#14985 pauses tracking when invoking function refs, so a function ref reading a component's exposed template ref (assigned in a post job) is no longer re-invoked once the ref lands. Add createElementRef to @v-c/util which retries the resolution on nextTick with a sequence guard, and use it for trigger's setPopupRef/setTargetRef, UniqueProvider's setPopupRef (fixes unique mode first-open misplacement) and resize-observer's setWrapperRef. Ref: antdv-next/antdv-next#623

… Space.Compact on vue 3.5.39) On first open inside Space.Compact, Select's dropdown aligned against the adjacent compact item instead of the select itself. resolveToElement's comment-$el -> nextElementSibling fallback resolved trigger's Popup (still hidden by the getPopupContainer delay) to the neighboring input, and since vue 3.5.39 function refs are no longer re-invoked reactively (vuejs/core#14985) the stolen element stuck until the post-motion re-align. @v-c/util 1.0.21 skips the sibling guess when the component exposes an element contract (nativeElement/el/getElement), letting the ref retry and onPrepare seed the real popup element. Ref: #623

fix(runtime-core): pause tracking when invoking function refs

c8140cc

edison1105 added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Jun 18, 2026

edison1105 added the ready to merge The PR is ready to be merged. label Jun 18, 2026

edison1105 merged commit 3ac052b into main Jun 25, 2026
16 checks passed

edison1105 deleted the edison/fix/runtime-core-function-ref-tracking branch June 25, 2026 08:16

szwjonks mentioned this pull request Jul 1, 2026

[Bug]: Chart instance ref remains null with Vue 3.5.39 apertureless/vue-chartjs#1122

Open

1 task

aibayanyu20 mentioned this pull request Jul 2, 2026

所有的浮层组件(Popconfirm/Tooltip/Popover等)在vue3.5.39下异常 antdv-next/antdv-next#623

Closed

4 tasks

cc-hearts mentioned this pull request Jul 2, 2026

fix(trigger): capture popup element via callback for Vue 3.5.39 compat antdv-next/vue-components#61

Closed

aibayanyu20 mentioned this pull request Jul 2, 2026

Function refs on components are invoked before exposed template refs become available since 3.5.39 #15039

Open

aibayanyu20 mentioned this pull request Jul 2, 2026

fix: vue 3.5.39 compatibility (function-ref element resolve) (#623) antdv-next/antdv-next#626

Merged

cc-hearts mentioned this pull request Jul 2, 2026

fix: use createElementRef for BubbleList refs antdv-next/x#113

Merged

17 tasks

aibayanyu20 mentioned this pull request Jul 3, 2026

fix(deps): bump @v-c/util to ^1.0.21 to fix Select dropdown misalign in Space.Compact (vue 3.5.39) antdv-next/antdv-next#629

Merged

ifer47 mentioned this pull request Jul 3, 2026

fix(runtime-core): defer component function refs (fix #15039) #15041

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(runtime-core): pause tracking when invoking function refs#14985

fix(runtime-core): pause tracking when invoking function refs#14985
edison1105 merged 1 commit into
mainfrom
edison/fix/runtime-core-function-ref-tracking

edison1105 commented Jun 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 18, 2026 •

edited

Loading

Walkthrough

Estimated code review effort

Suggested labels

Poem

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

pkg-pr-new Bot commented Jun 18, 2026

Uh oh!

edison1105 commented Jun 18, 2026

Uh oh!

vue-bot commented Jun 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

edison1105 commented Jun 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Suggested labels

Poem

Uh oh!

github-actions Bot commented Jun 18, 2026

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new Bot commented Jun 18, 2026

Uh oh!

edison1105 commented Jun 18, 2026

Uh oh!

vue-bot commented Jun 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

edison1105 commented Jun 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 18, 2026 •

edited

Loading