fix(teleport): handle teleport unmount edge case by edison1105 · Pull Request #12705 · vuejs/core

edison1105 · 2025-01-14T01:16:14Z

github-actions · 2025-01-14T01:17:14Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	106 kB (+16 B)	40.2 kB (+14 B)	36.1 kB (+28 B)
vue.global.prod.js	164 kB (+16 B)	60.2 kB (+16 B)	53.5 kB (+39 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	48.8 kB	19 kB	17.4 kB
createApp	56.9 kB	22 kB	20.1 kB
createSSRApp	61.2 kB	23.8 kB	21.7 kB
defineCustomElement	63.1 kB	23.9 kB	21.8 kB
overall	71.7 kB	27.4 kB	25 kB

pkg-pr-new · 2025-01-14T01:18:20Z

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12705

npm i https://pkg.pr.new/@vue/compiler-core@12705

yarn add https://pkg.pr.new/@vue/compiler-core@12705.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12705

npm i https://pkg.pr.new/@vue/compiler-dom@12705

yarn add https://pkg.pr.new/@vue/compiler-dom@12705.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12705

npm i https://pkg.pr.new/@vue/compiler-sfc@12705

yarn add https://pkg.pr.new/@vue/compiler-sfc@12705.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12705

npm i https://pkg.pr.new/@vue/compiler-ssr@12705

yarn add https://pkg.pr.new/@vue/compiler-ssr@12705.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12705

npm i https://pkg.pr.new/@vue/reactivity@12705

yarn add https://pkg.pr.new/@vue/reactivity@12705.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12705

npm i https://pkg.pr.new/@vue/runtime-core@12705

yarn add https://pkg.pr.new/@vue/runtime-core@12705.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12705

npm i https://pkg.pr.new/@vue/runtime-dom@12705

yarn add https://pkg.pr.new/@vue/runtime-dom@12705.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12705

npm i https://pkg.pr.new/@vue/server-renderer@12705

yarn add https://pkg.pr.new/@vue/server-renderer@12705.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12705

npm i https://pkg.pr.new/@vue/shared@12705

yarn add https://pkg.pr.new/@vue/shared@12705.tgz

vue

pnpm add https://pkg.pr.new/vue@12705

npm i https://pkg.pr.new/vue@12705

yarn add https://pkg.pr.new/vue@12705.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12705

npm i https://pkg.pr.new/@vue/compat@12705

yarn add https://pkg.pr.new/@vue/compat@12705.tgz

commit: 6848a15

coderabbitai · 2026-06-25T07:51:21Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c5d829f4-baa1-4827-a4e5-4b344c7a8519

📥 Commits

Reviewing files that changed from the base of the PR and between 643aa27 and 6848a15.

📒 Files selected for processing (2)

packages/runtime-core/__tests__/components/Teleport.spec.ts
packages/runtime-core/src/components/Teleport.ts

 _______________________________________________________________________________________________________________
< Make quality a requirements issue. Involve your users in determining the project's real quality requirements. >
 ---------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch edison/fix/12702

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-06-25T07:54:17Z

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{"name":"HttpError","status":500,"request":{"method":"PATCH","url":"https://api.github.com/repos/vuejs/core/issues/comments/4797040021","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.6 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- review_stack_entry_start -->\n\n[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/vuejs/core/pull/12705?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)\n\n<!-- review_stack_entry_end -->\n<!-- This is an auto-generated comment: review in progress by coderabbit.ai -->\n\n> [!NOTE]\n> Currently processing new changes in this PR. This may take a few minutes, please wait...\n> \n> <details>\n> <summary>⚙️ Run configuration</summary>\n> \n> **Configuration used**: defaults\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro\n> \n> **Run ID**: `c5d829f4-baa1-4827-a4e5-4b344c7a8519`\n> \n> </details>\n> \n> <details>\n> <summary>📥 Commits</summary>\n> \n> Reviewing files that changed from the base of the PR and between 643aa27b85bfa3f9607e3833d01831fc5363db76 and 6848a1504540f829b1748d47b1139d2596998a00.\n> \n> </details>\n> \n> <details>\n> <summary>📒 Files selected for processing (2)</summary>\n> \n> * `packages/runtime-core/__tests__/components/Teleport.spec.ts`\n> * `packages/runtime-core/src/components/Teleport.ts`\n> \n> </details>\n> \n> ```ascii\n>  ____________________________________________________________________________________________________________________________________________________________________\n> < Don't gather requirements - dig for them. Requirements rarely lie on the surface. They're buried deep beneath layers of assumptions, misconceptions, and politics. >\n>  --------------------------------------------------------------------------------------------------------------------------------------------------------------------\n>   \\\n>    \\   \\\n>         \\ /\\\n>         ( )\n>       .( o ).\n> ```\n\n<!-- end of auto-generated comment: review in progress by coderabbit.ai -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing Touches</summary>\n\n<details>\n<summary>📝 Generate docstrings</summary>\n\n- [ ] <!-- {\"checkboxId\": \"7962f53c-55bc-4827-bfbf-6a18da830691\"} --> Create stacked PR\n- [ ] <!-- {\"checkboxId\": \"3e1879ae-f29b-4d0d-8e06-d12b7ba33d98\"} --> Commit on current branch\n\n</details>\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"6ba7b810-9dad-11d1-80b4-00c04fd430c8\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Commit unit tests in branch `edison/fix/12702`\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n<!-- tips_start -->\n\n---\n\n\n\n\n<sub>Comment `@coderabbitai help` to get the list of available commands.</sub>\n\n<!-- tips_end -->"},"request":{"retryCount":3,"signal":{},"retries":3,"retryAfter":16}}}

edison1105 · 2026-06-25T07:54:50Z

/ecosystem-ci run

coderabbitai · 2026-06-25T07:55:15Z

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}

vue-bot · 2026-06-25T08:14:32Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
language-tools	✅ success	✅ success
vue-macros	✅ success	✅ success
quasar	✅ success	✅ success
vueuse	✅ success	✅ success
nuxt	✅ success	✅ success
radix-vue	❌ failure	❌ failure
vuetify	✅ success	❌ failure
vitepress	✅ success	❌ failure
vant	✅ success	✅ success
pinia	✅ success	✅ success
primevue	✅ success	✅ success
test-utils	✅ success	✅ success
vite-plugin-vue	✅ success	❌ failure
router	✅ success	✅ success
vue-i18n	✅ success	✅ success
vue-simple-compiler	✅ success	❌ failure

edison1105 added ready to merge The PR is ready to be merged. scope: teleport 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Jan 14, 2025

edison1105 added 3 commits June 25, 2026 15:39

fix(Teleport): handle teleport unmount edge case

2668e4c

chore: minor tweaks

cf3a446

test: add test case

6848a15

edison1105 force-pushed the edison/fix/12702 branch from 1b12b40 to 6848a15 Compare June 25, 2026 07:51

edison1105 changed the title ~~fix(Teleport): handle teleport unmount edge case~~ fix(teleport): handle teleport unmount edge case Jun 25, 2026

edison1105 merged commit 671997a into main Jun 25, 2026
16 checks passed

edison1105 deleted the edison/fix/12702 branch June 25, 2026 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(teleport): handle teleport unmount edge case#12705

fix(teleport): handle teleport unmount edge case#12705
edison1105 merged 3 commits into
mainfrom
edison/fix/12702

edison1105 commented Jan 14, 2025

Uh oh!

github-actions Bot commented Jan 14, 2025 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jan 14, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 25, 2026

Uh oh!

coderabbitai Bot commented Jun 25, 2026

Uh oh!

edison1105 commented Jun 25, 2026

Uh oh!

coderabbitai Bot commented Jun 25, 2026

Uh oh!

vue-bot commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

edison1105 commented Jan 14, 2025

Uh oh!

github-actions Bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new Bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 25, 2026

Uh oh!

coderabbitai Bot commented Jun 25, 2026

Uh oh!

edison1105 commented Jun 25, 2026

Uh oh!

coderabbitai Bot commented Jun 25, 2026

Uh oh!

vue-bot commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jan 14, 2025 •

edited

Loading

pkg-pr-new Bot commented Jan 14, 2025 •

edited

Loading