fix(types): support named tuple emits by edison1105 · Pull Request #12676 · vuejs/core

edison1105 · 2025-01-09T08:03:21Z

github-actions · 2025-01-09T08:04:28Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	106 kB	40.2 kB	36.1 kB
vue.global.prod.js	164 kB	60.2 kB	53.5 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	48.8 kB	19 kB	17.4 kB
createApp	56.9 kB	22 kB	20.1 kB
createSSRApp	61.2 kB	23.8 kB	21.7 kB
defineCustomElement	63.1 kB	23.9 kB	21.8 kB
overall	71.7 kB	27.4 kB	25 kB

pkg-pr-new · 2025-01-09T08:04:41Z

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12676

npm i https://pkg.pr.new/@vue/compiler-core@12676

yarn add https://pkg.pr.new/@vue/compiler-core@12676.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12676

npm i https://pkg.pr.new/@vue/compiler-dom@12676

yarn add https://pkg.pr.new/@vue/compiler-dom@12676.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12676

npm i https://pkg.pr.new/@vue/compiler-sfc@12676

yarn add https://pkg.pr.new/@vue/compiler-sfc@12676.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12676

npm i https://pkg.pr.new/@vue/compiler-ssr@12676

yarn add https://pkg.pr.new/@vue/compiler-ssr@12676.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12676

npm i https://pkg.pr.new/@vue/reactivity@12676

yarn add https://pkg.pr.new/@vue/reactivity@12676.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12676

npm i https://pkg.pr.new/@vue/runtime-core@12676

yarn add https://pkg.pr.new/@vue/runtime-core@12676.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12676

npm i https://pkg.pr.new/@vue/runtime-dom@12676

yarn add https://pkg.pr.new/@vue/runtime-dom@12676.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12676

npm i https://pkg.pr.new/@vue/server-renderer@12676

yarn add https://pkg.pr.new/@vue/server-renderer@12676.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12676

npm i https://pkg.pr.new/@vue/shared@12676

yarn add https://pkg.pr.new/@vue/shared@12676.tgz

vue

pnpm add https://pkg.pr.new/vue@12676

npm i https://pkg.pr.new/vue@12676

yarn add https://pkg.pr.new/vue@12676.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12676

npm i https://pkg.pr.new/@vue/compat@12676

yarn add https://pkg.pr.new/@vue/compat@12676.tgz

commit: a70fcf0

coderabbitai · 2026-06-25T07:58:26Z

Warning

Review limit reached

@edison1105, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 17 minutes and 40 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4e5930c5-2d8b-42dd-97c1-9befffaa8c43

📥 Commits

Reviewing files that changed from the base of the PR and between 643aa27 and a70fcf0.

📒 Files selected for processing (2)

packages-private/dts-test/defineComponent.test-d.tsx
packages/runtime-core/src/componentEmits.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch edison/fix/12673

_{Comment @coderabbitai help to get the list of available commands.}

edison1105 · 2026-06-25T08:10:23Z

/ecosystem-ci run

vue-bot · 2026-06-25T08:28:51Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
primevue	✅ success	✅ success
pinia	✅ success	✅ success
language-tools	✅ success	✅ success
vite-plugin-vue	✅ success	❌ failure
vant	✅ success	✅ success
nuxt	✅ success	✅ success
vue-simple-compiler	✅ success	❌ failure
vuetify	✅ success	❌ failure
router	✅ success	✅ success
vueuse	✅ success	✅ success
quasar	✅ success	✅ success
radix-vue	❌ failure	❌ failure
vue-i18n	✅ success	✅ success
test-utils	✅ success	✅ success
vitepress	✅ success	❌ failure
vue-macros	✅ success	✅ success

fix(types): EmitsOptions support named tuple syntax

5d549d2

edison1105 requested a review from jh-leong January 9, 2025 08:04

jh-leong approved these changes Jan 9, 2025

View reviewed changes

edison1105 marked this pull request as ready for review January 9, 2025 09:10

edison1105 added ready to merge The PR is ready to be merged. scope: types labels Jan 9, 2025

edison1105 added the 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. label Feb 18, 2025

coderabbitai Bot mentioned this pull request Apr 23, 2026

Maint/align frontend deps it-at-m/Praktikumsplaner#773

Merged

edison1105 added 2 commits June 25, 2026 15:53

Merge branch 'main' into edison/fix/12673

05a941a

fix(types): infer listener args for named tuple emits

a70fcf0

edison1105 changed the title ~~fix(types): EmitsOptions support named tuple syntax~~ fix(types): support named tuple emits Jun 25, 2026

vuejs deleted a comment from jh-leong Jun 25, 2026

edison1105 merged commit 232f402 into main Jun 25, 2026
16 checks passed

edison1105 deleted the edison/fix/12673 branch June 25, 2026 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(types): support named tuple emits#12676

fix(types): support named tuple emits#12676
edison1105 merged 3 commits into
mainfrom
edison/fix/12673

edison1105 commented Jan 9, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 9, 2025 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jan 9, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 25, 2026 •

edited

Loading

Review limit reached

Uh oh!

edison1105 commented Jun 25, 2026

Uh oh!

vue-bot commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

edison1105 commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new Bot commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

edison1105 commented Jun 25, 2026

Uh oh!

vue-bot commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

edison1105 commented Jan 9, 2025 •

edited

Loading

github-actions Bot commented Jan 9, 2025 •

edited

Loading

pkg-pr-new Bot commented Jan 9, 2025 •

edited

Loading

coderabbitai Bot commented Jun 25, 2026 •

edited

Loading