fix(test): fix flaky ctrl-c e2e test on macOS Rosetta CI#308
Merged
Conversation
9862cfb to
55cac33
Compare
Move "ctrl-c received" print from the signal handler to the main thread (after OnceLock::wait), so it always executes after the milestone flush println!(). Previously, std::process::exit(0) in the handler could terminate before output reached the PTY, causing flaky snapshot diffs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
55cac33 to
a4e6ea1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
println!()aftermark_milestoneinexit-on-ctrlc— the\nwas flaky on macOS Rosetta CI (sometimes lost in the PTY, causing snapshot mismatch)\n)OnceLockto wait for ctrl-c on the main thread instead ofstd::process::exit(0)in the signal handlerFailed job: https://github.com/voidzero-dev/vite-task/actions/runs/23702188288/job/69047978201
Test plan
🤖 Generated with Claude Code