vcsim: ModifyListView 'remove' does not return unresolved objects

dougm · dougm · commit fc91180a0c85 · 2024-10-03T19:09:54.000-07:00
From the sdk doc ModifyListView Return Value:
&gt; A list containing any objects in 'add' that could not be resolved
diff --git a/simulator/view_manager.go b/simulator/view_manager.go
@@ -275,9 +275,6 @@ func (v *ListView) ModifyListView(ctx *Context, req *types.ModifyListView) soap.
 
 	for _, ref := range req.Remove {
 		RemoveReference(&v.View, ref)
-		if ctx.Map.Get(ref) == nil {
-			body.Res.Returnval = append(body.Res.Returnval, ref)
-		}
 	}
 
 	if len(req.Remove) != 0 || len(req.Add) != 0 {
diff --git a/simulator/view_manager_test.go b/simulator/view_manager_test.go
@@ -222,5 +222,14 @@ func TestListViewModify(t *testing.T) {
 		if len(refs) != 1 {
 			t.Errorf("unresolved refs=%s", refs)
 		}
+
+		refs, err = list.Remove(ctx, add)
+		if err != nil {
+			log.Fatal(err)
+		}
+
+		if len(refs) != 0 {
+			t.Errorf("unresolved refs=%s", refs)
+		}
 	})
 }

Original file line number	Diff line number	Diff line change
`@@ -275,9 +275,6 @@ func (v ListView) ModifyListView(ctx Context, req *types.ModifyListView) soap.`
`275`	`275`
`276`	`276`	`for _, ref := range req.Remove {`
`277`	`277`	`RemoveReference(&v.View, ref)`
`278`		`- if ctx.Map.Get(ref) == nil {`
`279`		`- body.Res.Returnval = append(body.Res.Returnval, ref)`
`280`		`- }`
`281`	`278`	`}`
`282`	`279`
`283`	`280`	`if len(req.Remove) != 0 \|\| len(req.Add) != 0 {`