Skip to content

fix(typecheck): update get-tsconfig 4.7.3 to fix false circularity error#5384

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
hi-ogawa:chore-deps-get-tsconfig-circular
Mar 14, 2024
Merged

fix(typecheck): update get-tsconfig 4.7.3 to fix false circularity error#5384
sheremet-va merged 1 commit intovitest-dev:mainfrom
hi-ogawa:chore-deps-get-tsconfig-circular

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Mar 14, 2024

Description

Closes #5326

get-tsconfig is bundled dep, so I updated a version manually to get the fix.
Do you usually do this? or should I just wait for renovate to pick it up?

Test plan: I locally run the reproduction to confirm the fix.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Circularity detected while resolving configuration

2 participants