Skip to content

fix: fix vi.defineHelper called as object method#10163

Merged
sheremet-va merged 2 commits into
vitest-dev:mainfrom
hi-ogawa:fix-fix-vi-definehelper-called-as-object-method
Apr 20, 2026
Merged

fix: fix vi.defineHelper called as object method#10163
sheremet-va merged 2 commits into
vitest-dev:mainfrom
hi-ogawa:fix-fix-vi-definehelper-called-as-object-method

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Description

The other PR's fix is incomplete and not sure if it gets response, so this PR supersedes it.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify

netlify Bot commented Apr 20, 2026

Copy link
Copy Markdown

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 652449c
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69e5938458a9040008ba84cd
😎 Deploy Preview https://deploy-preview-10163--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review April 20, 2026 02:58
@sheremet-va sheremet-va merged commit 122c25b into vitest-dev:main Apr 20, 2026
23 checks passed
@hi-ogawa hi-ogawa deleted the fix-fix-vi-definehelper-called-as-object-method branch April 20, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vi.defineHelper's error stack points inside helper when called as an method

2 participants