feat: track dependencies when loading config with native#22602
Merged
sapphi-red merged 5 commits intoJun 12, 2026
Conversation
Member
Author
|
/ecosystem-ci run |
@vitejs/plugin-legacy
vite
commit: |
|
📝 Ran ecosystem CI on
✅ laravel, analogjs, nuxt, sveltekit, qwik, vite-plugin-svelte, vite-plugin-react, unocss, vite-plugin-vue, module-federation, vitepress, vite-setup-catalogue, vite-plugin-pwa, vite-environment-examples, quasar, waku, vuepress, vite-plugin-rsc, storybook |
Member
Author
|
I just found out that deno supports |
bluwy
reviewed
Jun 10, 2026
bluwy
approved these changes
Jun 12, 2026
foreverrbum
added a commit
to foreverrbum/ai-code-review
that referenced
this pull request
Jun 15, 2026
…t() not language() The _load_language helper called mod.language() for all grammars, but tree_sitter_typescript exports language_typescript() and language_tsx() rather than the generic language() that Python, JS, and Go use. The AttributeError was silently swallowed, so TypeScript AST extraction (function bodies, call sites, imports) returned empty results for every .ts/.tsx file. Fix: store the exact exported function name per extension in the mapping dict and call getattr(mod, func_name)() instead of mod.language(). Also add arrow_function to FUNCTION_NODE_TYPES for ts/tsx so const-assigned arrow functions are extracted alongside declarations. Caught by testing against vitejs/vite#22602 — zero function bodies retrieved from a 87K-char config.ts before the fix; 39 functions and both changed bodies extracted correctly after. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for restarting the server when the dependency of the config file is edited for Node. This does not work in
deno andbun as they don't support loaders.The tests are not added but it is covered on the dep side.
close #21655
part of #21546