perf: only bundle node version debug#19715
Merged
patak-cat merged 1 commit intovitejs:mainfrom Mar 31, 2025
Merged
Conversation
debug for nodedebug
patak-cat
approved these changes
Mar 31, 2025
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
debugcontains code for both browsers and node. The default entrypoint detects the runtime and uses the corresponding file.In our case, we know that we only run on node, and the browser code is not needed.
I set alias to
debugto resolve to the file that will be used for node.This PR reduces the compressed package size for 6kB. Not big, but I think the change is simple enough.