Conversation
|
I found these snippets: https://psalm.dev/r/1c176ef8bd<?php
/**
* @psalm-immutable
*/
final class Box
{
private function __construct(
private mixed $value,
) {
}
/**
* @psalm-pure
*/
#[\NoDiscard]
public static function of(mixed $value): self
{
return new self($value);
}
} |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using the new
NoDiscardattribute on a named constructor of a immutable class and that this named constructor is declared pure then Psalm6.14returns an errorImpureMethodCallon the attribute.Example code: https://psalm.dev/r/1c176ef8bd
Fix
Declare the
NoDiscardclass as immutable.Note
I tried creating a test (by looking at the
OverrideTestas an example) but it errors withThe class NoDiscard doesn't have the Attribute attribute. So far I haven't had the time to investigate how to fix that.