✨ Full support for iterables for iterator_to_array#11430
Merged
Conversation
Contributor
Author
|
Psalm check fails locally with |
Contributor
Author
|
My fixes may not cover all possible use-cases - changed with xdebug according to my intuition :) Please guide me in case of needed improvements |
Contributor
Author
|
CI fails for "test-with-real-projects" (phpunit) with most of the errors Should we patch the Psalm configuration in the used PHPUnit fork to disable the "ensure override" feature to match PHPUnit's codestyle? |
Contributor
Author
|
@danog can I help to proceed the PR? |
Collaborator
|
Looks good, thank you! |
Contributor
Contributor
|
cc @andrew-demb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11007, #8824