Skip to content

Deduplicate loop analysis#10782

Merged
orklah merged 2 commits intovimeo:6.xfrom
theodorejb:dedupe-loop-analysis
Feb 19, 2025
Merged

Deduplicate loop analysis#10782
orklah merged 2 commits intovimeo:6.xfrom
theodorejb:dedupe-loop-analysis

Conversation

@theodorejb
Copy link
Contributor

Also fixed some risky truthy falsy comparisons.

@theodorejb theodorejb force-pushed the dedupe-loop-analysis branch from 032910a to 612f0a1 Compare March 3, 2024 18:22
@theodorejb theodorejb force-pushed the dedupe-loop-analysis branch from 612f0a1 to 0796865 Compare March 3, 2024 19:50
@theodorejb theodorejb force-pushed the dedupe-loop-analysis branch from 0796865 to bccec0c Compare March 15, 2024 13:41
@theodorejb
Copy link
Contributor Author

@weirdan Does anything prevent merging this?

@weirdan
Copy link
Collaborator

weirdan commented Mar 20, 2024

@theodorejb I've been meaning to play with it locally, but haven't found the time yet. One thing that caught my eye is the type change for $protected_var_ids - perhaps there's a reason for that, but it's not immediately apparent.

@theodorejb
Copy link
Contributor Author

theodorejb commented Mar 20, 2024

@weirdan array<string, bool|int> seems to be the correct type for $protected_var_ids, since it's assigned to from a property with the same name in LoopScope, which has that type. The LoopScope property has that type because in one place it's assigned to from an array merge with $assigned_var_ids, which has a type of array<string, int>.

@theodorejb theodorejb force-pushed the dedupe-loop-analysis branch from 2176519 to cb4158a Compare July 1, 2024 16:36
@theodorejb theodorejb force-pushed the dedupe-loop-analysis branch from cb4158a to f4535c1 Compare October 5, 2024 19:45
@theodorejb
Copy link
Contributor Author

@weirdan I'm still hoping this can be reviewed/merged. It will make future contributions easier to make without introducing bugs or discrepancies.

@orklah
Copy link
Collaborator

orklah commented Feb 16, 2025

Hey, sorry for not answering earlier. If this was finished, could you rebase on 6.x?

Also remove some risky truthy falsy comparisons
@theodorejb theodorejb changed the base branch from 5.x to 6.x February 19, 2025 05:10
@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Feb 19, 2025
@orklah
Copy link
Collaborator

orklah commented Feb 19, 2025

Thanks!

@orklah orklah merged commit 86da1e5 into vimeo:6.x Feb 19, 2025
49 of 52 checks passed
@theodorejb theodorejb deleted the dedupe-loop-analysis branch February 19, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:fix The PR will be included in 'Fixes' section of the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants