Fix parameter having `object` type in PHPDoc and only `&` in the method's definition, used with code having an object calling it's method with itself as an argument for mentioned parameter by kubawerlos · Pull Request #10104 · vimeo/psalm

kubawerlos · 2023-08-12T10:35:49Z

Sorry for the title, see the explanation below:

Having such code:

<?php
class Foo {
    /**
    * @param object $o
    */
    public function bar(&$o): void {}
}
$x = new Foo();
$x->bar($x);

will result in internal Psalm error.

Removing object from PHPDoc, or
removing & from the function's definition, or
not passing $x to method of $x

will result in Psalm not crashing, so this is quite an edge case.

psalm-github-bot · 2023-08-12T10:35:53Z

I found these snippets:

https://psalm.dev/r/3374fc1feb

<?php
class Foo {
    /**
    * @param object $o
    */
    public function bar(&$o): void {}
}
$x = new Foo();
$x->bar($x);

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/MethodCallAnalyzer.php: We must have some types here!

weirdan · 2023-08-12T16:35:45Z

Thanks!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [google/protobuf](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf-php)) | require | minor | `3.23.4` -> `3.24.1` | | [grpc/grpc](https://grpc.io) ([source](https://togithub.com/grpc/grpc-php)) | require | minor | `1.52.0` -> `1.57.0` | | [phpstan/phpstan](https://togithub.com/phpstan/phpstan) | require-dev | patch | `1.10.27` -> `1.10.29` | | [phpunit/phpunit](https://phpunit.de/) ([source](https://togithub.com/sebastianbergmann/phpunit)) | require-dev | patch | `10.3.1` -> `10.3.2` | | [vimeo/psalm](https://togithub.com/vimeo/psalm) | require-dev | minor | `5.14.1` -> `5.15.0` | --- ### Release Notes <details> <summary>protocolbuffers/protobuf-php (google/protobuf)</summary> ### [`v3.24.1`](https://togithub.com/protocolbuffers/protobuf-php/compare/v3.24.0...v3.24.1) [Compare Source](https://togithub.com/protocolbuffers/protobuf-php/compare/v3.24.0...v3.24.1) ### [`v3.24.0`](https://togithub.com/protocolbuffers/protobuf-php/compare/v3.23.4...v3.24.0) [Compare Source](https://togithub.com/protocolbuffers/protobuf-php/compare/v3.23.4...v3.24.0) </details> <details> <summary>grpc/grpc-php (grpc/grpc)</summary> ### [`v1.57.0`](https://togithub.com/grpc/grpc-php/compare/v1.52.0...v1.57.0) [Compare Source](https://togithub.com/grpc/grpc-php/compare/v1.52.0...v1.57.0) </details> <details> <summary>phpstan/phpstan (phpstan/phpstan)</summary> ### [`v1.10.29`](https://togithub.com/phpstan/phpstan/releases/tag/1.10.29) [Compare Source](https://togithub.com/phpstan/phpstan/compare/1.10.28...1.10.29) # Improvements 🔧 - Update nikic/php-parser to v4.17.1 - PHP 8.3 features are no longer parse errors. Full-fledged PHP 8.3 support is coming later this year. - Update BetterReflection to 6.12.0 # Bugfixes 🐛 - PHPStan Pro - when launching, `PHP_BINARY` needs to be escaped (phpstan/phpstan-src@2c7cfd8) # Function signature fixes 🤖 - Fix FTP-related function signatures ([#2551](https://togithub.com/phpstan/phpstan-src/pull/2551)), thanks [@thg2k](https://togithub.com/thg2k)! ### [`v1.10.28`](https://togithub.com/phpstan/phpstan/releases/tag/1.10.28) [Compare Source](https://togithub.com/phpstan/phpstan/compare/1.10.27...1.10.28) # Improvements 🔧 - Update BetterReflection to 6.12.0 (phpstan/phpstan-src@7c49c94) # Bugfixes 🐛 - Nullsafe operator on `null` results in `null` (phpstan/phpstan-src@5c40c85), [#9721](https://togithub.com/phpstan/phpstan/issues/9721) - Properties set in the native constructor are initialized in additional constructors (phpstan/phpstan-src@1b0c6a0), [#9619](https://togithub.com/phpstan/phpstan/issues/9619) - Fix performance problem with nested BooleanOr and BooleanAnd (phpstan/phpstan-src@9adae6c), [#9690](https://togithub.com/phpstan/phpstan/issues/9690), [#9676](https://togithub.com/phpstan/phpstan/issues/9676) - CallableTypeHelper - copy variadic parameters if the accepting closure has more parameters (phpstan/phpstan-src@31ed326), [#9699](https://togithub.com/phpstan/phpstan/issues/9699) # Internals 🔍 - Simplify access to ClassReflection in ClassPropertyNode ([#2565](https://togithub.com/phpstan/phpstan-src/pull/2565)), thanks [@mad-briller](https://togithub.com/mad-briller)! </details> <details> <summary>sebastianbergmann/phpunit (phpunit/phpunit)</summary> ### [`v10.3.2`](https://togithub.com/sebastianbergmann/phpunit/compare/10.3.1...10.3.2) [Compare Source](https://togithub.com/sebastianbergmann/phpunit/compare/10.3.1...10.3.2) </details> <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.15.0`](https://togithub.com/vimeo/psalm/releases/tag/5.15.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.14.1...5.15.0)  #### What's Changed ##### Features - Check if argument passed to isset() is not a variable by [@Nitamet](https://togithub.com/Nitamet) in [https://github.com/vimeo/psalm/pull/10068](https://togithub.com/vimeo/psalm/pull/10068) - Fix [#9997](https://togithub.com/vimeo/psalm/issues/9997) dynamic properties on SimpleXmlElement by [@ygottschalk](https://togithub.com/ygottschalk) in [https://github.com/vimeo/psalm/pull/10049](https://togithub.com/vimeo/psalm/pull/10049) - Nicer PHP version checking by [@Nitamet](https://togithub.com/Nitamet) in [https://github.com/vimeo/psalm/pull/10129](https://togithub.com/vimeo/psalm/pull/10129) ##### Fixes - Fixed `DOMDocument::load*` signatures by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10073](https://togithub.com/vimeo/psalm/pull/10073) - make (s)printf error reporting more correct/literal by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10088](https://togithub.com/vimeo/psalm/pull/10088) - Fix parameter having `object` type in PHPDoc and only `&` in the method's definition, used with code having an object calling it's method with itself as an argument for mentioned parameter by [@kubawerlos](https://togithub.com/kubawerlos) in [https://github.com/vimeo/psalm/pull/10104](https://togithub.com/vimeo/psalm/pull/10104) - mysqli_field_seek returns true by [@kamil-tekiela](https://togithub.com/kamil-tekiela) in [https://github.com/vimeo/psalm/pull/10107](https://togithub.com/vimeo/psalm/pull/10107) - Fix bcdiv nullable scale stub by [@TheDevick](https://togithub.com/TheDevick) in [https://github.com/vimeo/psalm/pull/10106](https://togithub.com/vimeo/psalm/pull/10106) - Cleanup `test` command and `fixAll` action by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10108](https://togithub.com/vimeo/psalm/pull/10108) - Correct type for `$enum->name` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10109](https://togithub.com/vimeo/psalm/pull/10109) - argv and argc were inconsistent in Context with VariableFetchAnalyzer by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10093](https://togithub.com/vimeo/psalm/pull/10093) - Fix `hash_pbkdf2` `$options` parameter by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10110](https://togithub.com/vimeo/psalm/pull/10110) - Forbid faulty `nikic/php-parser` version by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10112](https://togithub.com/vimeo/psalm/pull/10112) - `strip_tags()/$allowed_tags` can accept arrays since 7.4 by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10122](https://togithub.com/vimeo/psalm/pull/10122) - Fix crash when assertion array is not a list by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10123](https://togithub.com/vimeo/psalm/pull/10123) - Fix crash on array access to undefined class by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10134](https://togithub.com/vimeo/psalm/pull/10134) - Correct exit code for invalid version format by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10135](https://togithub.com/vimeo/psalm/pull/10135) #### New Contributors - [@Nitamet](https://togithub.com/Nitamet) made their first contribution in [https://github.com/vimeo/psalm/pull/10068](https://togithub.com/vimeo/psalm/pull/10068) - [@TheDevick](https://togithub.com/TheDevick) made their first contribution in [https://github.com/vimeo/psalm/pull/10106](https://togithub.com/vimeo/psalm/pull/10106) **Full Changelog**: vimeo/psalm@5.14.1...5.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-php).  Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vimeo/psalm](https://togithub.com/vimeo/psalm) | require-dev | minor | `~5.14.0` -> `~5.15.0` | --- ### Release Notes <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.15.0`](https://togithub.com/vimeo/psalm/releases/tag/5.15.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.14.1...5.15.0)  #### What's Changed ##### Features - Check if argument passed to isset() is not a variable by [@Nitamet](https://togithub.com/Nitamet) in [https://github.com/vimeo/psalm/pull/10068](https://togithub.com/vimeo/psalm/pull/10068) - Fix [#9997](https://togithub.com/vimeo/psalm/issues/9997) dynamic properties on SimpleXmlElement by [@ygottschalk](https://togithub.com/ygottschalk) in [https://github.com/vimeo/psalm/pull/10049](https://togithub.com/vimeo/psalm/pull/10049) - Nicer PHP version checking by [@Nitamet](https://togithub.com/Nitamet) in [https://github.com/vimeo/psalm/pull/10129](https://togithub.com/vimeo/psalm/pull/10129) ##### Fixes - Fixed `DOMDocument::load*` signatures by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10073](https://togithub.com/vimeo/psalm/pull/10073) - make (s)printf error reporting more correct/literal by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10088](https://togithub.com/vimeo/psalm/pull/10088) - Fix parameter having `object` type in PHPDoc and only `&` in the method's definition, used with code having an object calling it's method with itself as an argument for mentioned parameter by [@kubawerlos](https://togithub.com/kubawerlos) in [https://github.com/vimeo/psalm/pull/10104](https://togithub.com/vimeo/psalm/pull/10104) - mysqli_field_seek returns true by [@kamil-tekiela](https://togithub.com/kamil-tekiela) in [https://github.com/vimeo/psalm/pull/10107](https://togithub.com/vimeo/psalm/pull/10107) - Fix bcdiv nullable scale stub by [@TheDevick](https://togithub.com/TheDevick) in [https://github.com/vimeo/psalm/pull/10106](https://togithub.com/vimeo/psalm/pull/10106) - Cleanup `test` command and `fixAll` action by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10108](https://togithub.com/vimeo/psalm/pull/10108) - Correct type for `$enum->name` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10109](https://togithub.com/vimeo/psalm/pull/10109) - argv and argc were inconsistent in Context with VariableFetchAnalyzer by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10093](https://togithub.com/vimeo/psalm/pull/10093) - Fix `hash_pbkdf2` `$options` parameter by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10110](https://togithub.com/vimeo/psalm/pull/10110) - Forbid faulty `nikic/php-parser` version by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10112](https://togithub.com/vimeo/psalm/pull/10112) - `strip_tags()/$allowed_tags` can accept arrays since 7.4 by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10122](https://togithub.com/vimeo/psalm/pull/10122) - Fix crash when assertion array is not a list by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10123](https://togithub.com/vimeo/psalm/pull/10123) - Fix crash on array access to undefined class by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10134](https://togithub.com/vimeo/psalm/pull/10134) - Correct exit code for invalid version format by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10135](https://togithub.com/vimeo/psalm/pull/10135) #### New Contributors - [@Nitamet](https://togithub.com/Nitamet) made their first contribution in [https://github.com/vimeo/psalm/pull/10068](https://togithub.com/vimeo/psalm/pull/10068) - [@TheDevick](https://togithub.com/TheDevick) made their first contribution in [https://github.com/vimeo/psalm/pull/10106](https://togithub.com/vimeo/psalm/pull/10106) **Full Changelog**: vimeo/psalm@5.14.1...5.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/php-sdk).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Add test

18a4752

Add fix

35183b9

kubawerlos marked this pull request as ready for review August 12, 2023 10:50

weirdan approved these changes Aug 12, 2023

View reviewed changes

weirdan added causes crash release:fix The PR will be included in 'Fixes' section of the release notes labels Aug 12, 2023

weirdan merged commit a69eddd into vimeo:5.x Aug 12, 2023

kubawerlos deleted the fix_MethodCallAnalyzer branch August 12, 2023 16:57

kubawerlos mentioned this pull request Aug 22, 2023

Remove exclude from Psalm tpay-com/tpay-openapi-php#34

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix parameter having `object` type in PHPDoc and only `&` in the method's definition, used with code having an object calling it's method with itself as an argument for mentioned parameter#10104

Fix parameter having `object` type in PHPDoc and only `&` in the method's definition, used with code having an object calling it's method with itself as an argument for mentioned parameter#10104
weirdan merged 2 commits intovimeo:5.xfrom
6b7562617765726c6f73:fix_MethodCallAnalyzer

kubawerlos commented Aug 12, 2023

Uh oh!

psalm-github-bot bot commented Aug 12, 2023

Uh oh!

weirdan commented Aug 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kubawerlos commented Aug 12, 2023

Uh oh!

psalm-github-bot bot commented Aug 12, 2023

Uh oh!

weirdan commented Aug 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants