Patch setHeader for direct route handlers#93101
Merged
Merged
Conversation
ztanner
approved these changes
Apr 21, 2026
ijjk
added a commit
that referenced
this pull request
Apr 21, 2026
## Summary - apply the `setHeader` cookie-support patch to direct route module handlers in `prepare()` - make `patchSetHeaderWithCookieSupport()` idempotent so both entry paths can call it safely - add an adapter-like direct RSC regression test that fails without the patch Closes: NEXT-4919 ## Testing - `NEXT_SKIP_ISOLATE=1 NEXT_TEST_MODE=start pnpm testheadless test/e2e/app-dir/cache-components/cache-components.test.ts -t "should ignore late setHeader calls for direct RSC handlers after headers are sent"` <!-- NEXT_JS_LLM_PR -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setHeadercookie-support patch to direct route module handlers inprepare()patchSetHeaderWithCookieSupport()idempotent so both entry paths can call it safelyCloses: NEXT-4919
Testing
NEXT_SKIP_ISOLATE=1 NEXT_TEST_MODE=start pnpm testheadless test/e2e/app-dir/cache-components/cache-components.test.ts -t "should ignore late setHeader calls for direct RSC handlers after headers are sent"