Skip to content

fix: update the config.api.responseLimit type#82852

Merged
bgub merged 1 commit intocanaryfrom
fix/response-limit-type
Aug 20, 2025
Merged

fix: update the config.api.responseLimit type#82852
bgub merged 1 commit intocanaryfrom
fix/response-limit-type

Conversation

@bgub
Copy link
Copy Markdown
Contributor

@bgub bgub commented Aug 20, 2025

config.api.responseLimit can also be set to false. Because of the limitations of type inference on JS files, we need to set the type to boolean.

See #82842 (comment)

@bgub bgub requested review from ijjk and ztanner August 20, 2025 20:14
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Aug 20, 2025
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Aug 20, 2025

Tests Passed

@bgub bgub merged commit cad24f4 into canary Aug 20, 2025
284 of 289 checks passed
@bgub bgub deleted the fix/response-limit-type branch August 20, 2025 21:58
bgub added a commit that referenced this pull request Aug 25, 2025
`config.api.responseLimit` can also be [set to
`false`](#82842 (comment)).
Because of the limitations of type inference on JS files, we need to set
the type to `boolean`.

See
#82842 (comment)
bgub added a commit that referenced this pull request Aug 25, 2025
…3028)

`config.api.responseLimit` can also be [set to

`false`](#82842 (comment)).
Because of the limitations of type inference on JS files, we need to set
the type to `boolean`.

See
#82842 (comment)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
@github-actions github-actions Bot added the locked label Sep 4, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants