-
-
Notifications
You must be signed in to change notification settings - Fork 104
Add support for custom update sources in the C++ library #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
817ad38 to
40d17d8
Compare
40d17d8 to
9ee7507
Compare
|
Hey, thanks for this PR. I've rebased to latest, and pushed a new commit with some changes to the rust c header. Firstly, do you think the approach is on the right track? Secondly, if you agree with the direction would you mind updating the Velopack.hpp c++ header to align with the new C functions? To summarise,
I've not tested these changes yet. |
9ee7507 to
d800407
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #401 +/- ##
===========================================
- Coverage 47.05% 37.34% -9.71%
===========================================
Files 223 51 -172
Lines 13673 5992 -7681
Branches 1251 0 -1251
===========================================
- Hits 6434 2238 -4196
+ Misses 6906 3754 -3152
+ Partials 333 0 -333 ☔ View full report in Codecov by Sentry. |
|
@caesay Sorry, I just saw this. I guess you made reasonable choices? Please let me know if you'd like me to do anything more. Glad that the change is in main! |
|
The changes have been released, and there is an example in the |
|
I integrated with our app and tested it. It works as intended. |
This is an initial attempt. I managed to make this work with a private AWS S3 bucket as the update source. Please let me know if I need to update any tests or sample code