Skip to content

Conversation

@caesay
Copy link
Member

@caesay caesay commented Dec 1, 2024

Closes #367

@codecov
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.75%. Comparing base (e1f4c13) to head (e977e25).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #390      +/-   ##
===========================================
+ Coverage    39.97%   45.75%   +5.78%     
===========================================
  Files          225      225              
  Lines        13665    13676      +11     
  Branches      1221     1249      +28     
===========================================
+ Hits          5462     6258     +796     
+ Misses        7879     7103     -776     
+ Partials       324      315       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caesay caesay merged commit 7809223 into develop Dec 1, 2024
23 checks passed
@caesay caesay deleted the cs/diricon branch December 1, 2024 20:03
@ravener
Copy link

ravener commented Dec 2, 2024

@caesay, by the way, what about applications that use a custom AppDir? It'd still be helpful to copy this regardless of whether one is using a custom AppDir. Or is that too complicated, and they should handle it themselves?

@caesay
Copy link
Member Author

caesay commented Dec 3, 2024

For users who provide their own AppDir, I expect they have fully formed / valid AppDir and do not make any changes aside from copying our updater into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate .DirIcon for Linux AppImages

3 participants