Fix WithFirstRun not running on MacOS #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! I'll test this shortly but it looks great. |
Author
Brilliant thanks, looking forward to it getting released once we know it works :) |
Member
|
Your change did not work as intended, the app just failed to start. I have fixed this and merged. Thanks for getting the ball rolling on this in any case! |
Author
|
Thank you @caesay, apologies I wasn't able to validate it, spent hours trying to get my local environment setup to run it and gave up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have had trouble setting up my dev environment to correctly build the vpk CLI to test this change works.
Added a prefix of
export VELOPACK_FIRSTRUN=1to the initial run of the installed app triggered in the postinstall script.In theory, this should be available to Velopack to detect first run.
Closes #167