Implementing Azure Trusted Signing #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #330 +/- ##
===========================================
+ Coverage 46.87% 47.24% +0.36%
===========================================
Files 224 223 -1
Lines 13606 13619 +13
Branches 1249 1251 +2
===========================================
+ Hits 6378 6434 +56
+ Misses 6905 6852 -53
- Partials 323 333 +10 ☔ View full report in Codecov by Sentry. |
caesay
requested changes
Nov 7, 2024
Member
caesay
left a comment
There was a problem hiding this comment.
Have added some observations - also the tests are failing
src/vpk/Velopack.Packaging.Windows/Commands/WindowsPackCommandRunner.cs
Outdated
Show resolved
Hide resolved
caesay
previously approved these changes
Nov 27, 2024
WIP writing tests for Azure Code Signing Fix issue to make sure we sign at least one file at a time "Working" test with manually providing dependencies Work on download dependencies. Revert signtool.exe change
|
Do the docs from April 2024 still apply for signing with ATS in GH actions? Or did this change with this PR ? |
Member
|
The docs are up to date. April 2024 refers to when ATS was launched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.