-
-
Notifications
You must be signed in to change notification settings - Fork 104
Improve Unity sample #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Unity sample #316
Conversation
|
I see in the Packages folder, there are a bunch of nuget binaries. Can this be added to gitignore and restored when compiling? |
|
Good question. The answer is yes, if we remove the nuget binaries, they will be restored when compiling. If "Ignore" is pressed, several errors will be shown in the console: After this errors are generated, the nugets will be downloaded and installed, so no user action is really needed (apart from selecting "Ignore"). This will happen only the first time the project is opened. After that, the nuget files would be restored and no error would be shown. So we can: As a note, the nuget package versions are stated on packages.config, so including binaries or not, the result would be the same. What should we do? |
|
I don't really want the nuget packages committed into our git repo. I think maybe we can add something to the readme about the warnings coming up the first time. |
|
Done! What do you think now? |
|
Awesome! I'm not able to test this myself but it looks good. Thanks a lot. I do think we can improve the Unity story with Velopack further though, it would be nice to eliminate that C++ project? If you want to have a discussion about further improvements please message me on Discord |


Why?
Following the instructions on the README of the Unity sample is not straightforward. .sln generation and building are left to the user and results may differ depending on how the user approaches it.
What?
Future work?