Revert back to the old AppImageKit runtime #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 403c33e.
Was the previous default prior to velopack#243.
These args were also the previous default for velopack, pre-type2 runtime + zstd.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #257 +/- ##
===========================================
- Coverage 47.36% 46.13% -1.24%
===========================================
Files 220 220
Lines 12939 12946 +7
Branches 1225 1226 +1
===========================================
- Hits 6128 5972 -156
- Misses 6497 6666 +169
+ Partials 314 308 -6 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Anecdotal evidence from one of our users previously struggling with AppImageLauncher, saying it now works: https://discord.com/channels/188630481301012481/1097318920991559880/1293955248532094986 |
smoogipoo
added a commit
to smoogipoo/osu-deploy
that referenced
this pull request
Oct 10, 2024
velopack/velopack#257 has been merged in so the custom package is no longer required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Feel free to close this PR if it's not going in the direction you want.
It turns out that the new AppImage runtime does not play nice with an external tool called AppImageLauncher, which simply doesn't seem to support the type-2 runtime: AppImage/type2-runtime#12
Resulting in many projects experiencing issues:
We've tried zstd (new default) and zlib, and the problem can't be resolved by changing the compressor - AppImageLauncher is simply incompatible with the type-2 runtime.
Velopack switched to type-2 upon our request, because we wanted to use
zstdcompression. This was my mistake, because we were actually usingzlib. The PRs involved were:This PR partially reverts the above:
xz, the previous default. The idea here is to revert to what was known to work well for Velopack, but I can change togzipupon rqeuest.xzcompressor args, as per previous implementation, and which are good defaults according toAppImageKit. I'm not sure what to do about the Windows path here, but it might be fine not specifying any args as this is what was originally there. Of note, 128K is the default block size [1] [2]gzip.I have tested both
gzipandxzcompressed apps to run, however I have not tested in conjunction withAppImageLauncher.