Fixing double runs when pushing to a branch with an open PR #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if you push to a branch with an open PR, both the PR and an push triggers fire, causing the workflow to run twice. This limits it to only run on pushes to develop and master, or on PRs to those branches. This also adds in a workflow_dispatch trigger to be able to manually kick runs from any branch if desired.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #248 +/- ##
===========================================
- Coverage 49.30% 48.79% -0.52%
===========================================
Files 217 220 +3
Lines 12513 12646 +133
Branches 1223 1223
===========================================
Hits 6170 6170
- Misses 6029 6162 +133
Partials 314 314 ☔ View full report in Codecov by Sentry. |
Member
|
I noticed this too. Technically actions minutes are free on public repos, so I wasn't too worried about it. But it could help reduce collisions in our deployment/upload tests so I am happy with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you push to a branch with an open PR, both the PR and an push triggers fire, causing the workflow to run twice. This limits it to only run on pushes to develop and master, or on PRs to those branches.
This also adds in a workflow_dispatch trigger to be able to manually kick runs from any branch if desired.