Skip to content

DRAFT: Add lib-nodejs, refactor lib-rust, fix bugs #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caesay merged 106 commits into from
Oct 8, 2024
Merged

DRAFT: Add lib-nodejs, refactor lib-rust, fix bugs #244

caesay merged 106 commits into from
Oct 8, 2024

Conversation

@caesay
Copy link
Member

@caesay caesay commented Sep 27, 2024 •
edited
Loading

@caesay caesay mentioned this pull request Sep 27, 2024
Closed
@caesay caesay force-pushed the cs/node-lib branch 4 times, most recently from f50ec6d to b011741 Compare October 1, 2024 16:20
@codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.31267% with 1065 lines in your changes missing coverage. Please review.

Project coverage is 10.46%. Comparing base (48946fd) to head (cae60d2).
Report is 106 commits behind head on develop.

Files with missing lines Patch % Lines
src/lib-rust/src/bundle.rs 17.51% 226 Missing ⚠️
src/lib-nodejs/velopack_nodeffi/src/lib.rs 0.00% 218 Missing ⚠️
src/lib-rust/src/locator.rs 0.00% 212 Missing ⚠️
src/lib-rust/src/manager.rs 0.00% 98 Missing ⚠️
src/lib-rust/src/app.rs 0.00% 95 Missing ⚠️
src/lib-nodejs/velopack_nodeffi/src/logger.rs 0.00% 68 Missing ⚠️
src/lib-rust/src/sources.rs 0.00% 53 Missing ⚠️
src/bins/src/commands/apply.rs 0.00% 18 Missing ⚠️
src/lib-rust/src/util.rs 0.00% 17 Missing ⚠️
src/bins/src/commands/apply_osx_impl.rs 0.00% 15 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop     #244       +/-   ##
============================================
- Coverage    48.73%   10.46%   -38.28%     
============================================
  Files          221       27      -194     
  Lines        12661     2208    -10453     
  Branches      1225        0     -1225     
============================================
- Hits          6170      231     -5939     
+ Misses        6177     1977     -4200     
+ Partials       314        0      -314

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

caesay added 24 commits October 7, 2024 10:56
@caesay caesay marked this pull request as ready for review October 8, 2024 03:31
@caesay caesay merged commit d32e011 into develop Oct 8, 2024
@caesay caesay deleted the cs/node-lib branch October 8, 2024 03:31
@dependabot dependabot bot mentioned this pull request Jul 28, 2025
Closed
@dependabot dependabot bot mentioned this pull request Aug 19, 2025
Closed
@dependabot dependabot bot mentioned this pull request Oct 27, 2025
Closed
@dependabot dependabot bot mentioned this pull request Dec 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@caesay