Add support for streaming identity-encoded or unknown length response bodies#2000
Merged
erikdubbelboer merged 1 commit intovalyala:masterfrom May 3, 2025
Merged
Add support for streaming identity-encoded or unknown length response bodies#2000erikdubbelboer merged 1 commit intovalyala:masterfrom
erikdubbelboer merged 1 commit intovalyala:masterfrom
Conversation
osxtest
commented
Apr 30, 2025
| } | ||
| left := rs.header.ContentLength() - rs.totalBytesRead | ||
| if len(p) > left { | ||
| if left > 0 && len(p) > left { |
Contributor
Author
There was a problem hiding this comment.
Update the read size of p only when left is greater than zero.
leftcannot be zero here, as the previous checkif rs.totalBytesRead == rs.header.ContentLength() { ... }already handles that case.leftmay be negative ifrs.header.ContentLength()returns-2, which can occur whenTransfer-Encoding: identityis used or whenContent-Lengthis not provided.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for streaming response bodies when the
Transfer-Encodingis identity (or whenContent-Lengthis not provided).