Fix round robin addresses in dual stack dialing#1995
Merged
erikdubbelboer merged 1 commit intovalyala:masterfrom Apr 11, 2025
Merged
Fix round robin addresses in dual stack dialing#1995erikdubbelboer merged 1 commit intovalyala:masterfrom
erikdubbelboer merged 1 commit intovalyala:masterfrom
Conversation
raviqqe
commented
Apr 11, 2025
| n := uint32(len(addrs)) // #nosec G115 | ||
| for n > 0 { | ||
| for range n { | ||
| conn, err = d.tryDial(network, addrs[idx%n].String(), deadline, d.concurrencyCh) |
Contributor
Author
There was a problem hiding this comment.
In this statement, the variable n should not change over different iterations of the loop while we want to try n addresses.
For example, in the previous implementation, if n is 2 and the initial idx is 2,
- In the first iteration,
idx % n = 2 % 2 = 0. - In the second iteration,
idx % n = 3 % 1 = 0. ;(
Collaborator
|
Nice find! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes round robin addresses in dual stack dialing.
Question
What and where is the best way to unit-test this fix?
References