feat: move user values to Request structure#1999
Merged
erikdubbelboer merged 1 commit intovalyala:masterfrom May 3, 2025
Merged
feat: move user values to Request structure#1999erikdubbelboer merged 1 commit intovalyala:masterfrom
erikdubbelboer merged 1 commit intovalyala:masterfrom
Conversation
Collaborator
|
Looks good to me. |
Contributor
Author
|
Thanks! Do you have any approximate date for new release? |
Collaborator
|
I will tag one next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving user values to Request structure is helpful to propagate context through many abstraction layers (e.g. for tracing/custom middlewares on client side).
Now it's impossible (or VERY awkward) to implement telemetry for client, since
Client.Dohave only request and response arguments.It solves #940 and many other issues.